-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renovate: maintenance renovate config/ci #2832
renovate: maintenance renovate config/ci #2832
Conversation
// use LTS node version for node docker image | ||
matchDatasources: ["docker"], | ||
matchPackageNames: ["node"], | ||
versioning: "node", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nodejs versioning use LTS
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/[email protected] | ||
- uses: suzuki-shunsuke/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I choose https://github.com/suzuki-shunsuke/github-action-renovate-config-validator, not
https://github.com/rinchsan/renovate-config-validator by following reasons.
- too simple implementation
- support renovate.json5 without any configs
- https://github.com/suzuki-shunsuke#oss-development maintain too many terraform tools and aqua which is also upgrade by renovate
In addition, https://github.com/renovatebot/github-action doesn't support validation like renovatebot/github-action#548.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This action has very few stars. Is there not an action that is more widely accepted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems no other marketplace github actions for it. Otherwise we can do apt install npm && npx --package renovate -c 'renovate-config-validator'
. Is this better? (for me both ok)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it and found that there is no reason to use marketplace action, so change it.
Co-authored-by: nitrocode <[email protected]>
478f18c
to
985dd57
Compare
Thank you again @krrrr38 ! |
what / why
introduce https://github.com/suzuki-shunsuke/github-action-renovate-config-validatornpx --package renovate -c 'renovate-config-validator'
references